bugfix #15
Open
bugfix #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,7 +198,7 @@ def print_execute_reroutes(es_host, commands): | |||
| raise BalanceException('User exited serial rerouting!') | |||
|
|
|||
| cluster_update_interval = get_transient_cluster_settings( | |||
| es_host, 'cluster.info.update.interval', | |||
| es_host, ['cluster.info.update.interval'], | |||
There was a problem hiding this comment.
does this being a list or a string depend on the version of ES we're using?
There was a problem hiding this comment.
gchazot
approved these changes
Jul 18, 2023
| @@ -198,7 +198,7 @@ def print_execute_reroutes(es_host, commands): | |||
| raise BalanceException('User exited serial rerouting!') | |||
|
|
|||
| cluster_update_interval = get_transient_cluster_settings( | |||
| es_host, 'cluster.info.update.interval', | |||
| es_host, ['cluster.info.update.interval'], | |||
There was a problem hiding this comment.
fmcwalters-edited
approved these changes
Jul 19, 2023
|
@gchazot specifically this line here, if you pass it in as a string it's splitting on each individual letter instead of list items. I'm very surprised this hasn't come up before tbh... |
|
What's the status on this? It looks like this might be ready to merge and a new release of the tool could be published...? |
|
Yep it can, I'll deal with it today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR
Parts of the app this will impact
Todos
Additional information
Related links