Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for all heFFTe MPI communication backends #799

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rodrigoacb
Copy link

@rodrigoacb rodrigoacb commented Oct 30, 2024

This PR extends the available backends available in heFFTe using a enum class to pick the chosen reshape/communication pattern. 

Previously supported: alltoallv and p2p

This adds alltoall and p2p_plined

This changes were done in cooperation with @rhalver

@junghans junghans requested review from streeve and sslattery October 31, 2024 14:28
@streeve
Copy link
Member

streeve commented Oct 31, 2024

Thanks for the improvements! Do you mind splitting into two PRs? I think I'll want someone else to at least co-review the spline details, but the FFT should be quick to merge

@rodrigoacb
Copy link
Author

Thanks for the improvements! Do you mind splitting into two PRs? I think I'll want someone else to at least co-review the spline details, but the FFT should be quick to merge

Hi @streeve Sam! We also thank you for maintaining Cabana! I don't mind splitting the PRs. Should I leave this one for the FFT and create a new one for the Splines?

I had a look into the actions, and I think I have already addressed it with fixes that I can commit once the PRs are at the places.

@streeve
Copy link
Member

streeve commented Nov 4, 2024

Thanks for the improvements! Do you mind splitting into two PRs? I think I'll want someone else to at least co-review the spline details, but the FFT should be quick to merge

Hi @streeve Sam! We also thank you for maintaining Cabana! I don't mind splitting the PRs. Should I leave this one for the FFT and create a new one for the Splines?

I had a look into the actions, and I think I have already addressed it with fixes that I can commit once the PRs are at the places.

Yes, that sounds great!

@rodrigoacb rodrigoacb changed the title Add Splines of order 4 to 7 and support for all heFFTe MPI communication backends Add support for all heFFTe MPI communication backends Nov 5, 2024
@streeve
Copy link
Member

streeve commented Dec 6, 2024

@rodrigoacb sorry for the delay - we will want to rebase this to remove the splines. I'm happy to do that if needed

@rodrigoacb
Copy link
Author

Hi @streeve, no problem! Thanks, I will be happy if you can rebase to remove the splines and get the repo to the point it can be merged

@junghans junghans enabled auto-merge December 6, 2024 21:42
@streeve streeve disabled auto-merge December 9, 2024 15:29
@streeve streeve merged commit 8cf2599 into ECP-copa:master Dec 9, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants