-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for all heFFTe MPI communication backends #799
Conversation
Thanks for the improvements! Do you mind splitting into two PRs? I think I'll want someone else to at least co-review the spline details, but the FFT should be quick to merge |
Hi @streeve Sam! We also thank you for maintaining Cabana! I don't mind splitting the PRs. Should I leave this one for the FFT and create a new one for the Splines? I had a look into the actions, and I think I have already addressed it with fixes that I can commit once the PRs are at the places. |
Yes, that sounds great! |
@rodrigoacb sorry for the delay - we will want to rebase this to remove the splines. I'm happy to do that if needed |
Hi @streeve, no problem! Thanks, I will be happy if you can rebase to remove the splines and get the repo to the point it can be merged |
This PR extends the available backends available in heFFTe using a enum class to pick the chosen reshape/communication pattern.
Previously supported: alltoallv and p2p
This adds alltoall and p2p_plined
This changes were done in cooperation with @rhalver