-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor Load Balancing #541
base: master
Are you sure you want to change the base?
Conversation
Jenkins is failing because of the benchmark CMakeLists - I can start the other tests after that fix. This is a great start! I think we still want some separation of the sparse partitioning from the particle version, maybe a derived class. Particularly because the tile concept does not exist in the dense grid I like the |
@streeve That makes sense. Since particles and sparse map have quite different parameters to pass in the function, I am not sure how the derived class works here to address. Neither constructor does the job I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you'll need to merge/rebase master to fix the CI (error from the merged SparseLocalGrid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can run make doxygen
from your build to check for missing docs
benchmark/cajita/Cajita_ParticleDynamicPartitionerPerformance.cpp
Outdated
Show resolved
Hide resolved
benchmark/cajita/Cajita_SparseMapDynamicPartitionerPerformance.cpp
Outdated
Show resolved
Hide resolved
…alWorkloadBySparseMap
Co-authored-by: Sam Reeve <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #541 +/- ##
======================================
Coverage 94.8% 94.8%
======================================
Files 47 49 +2
Lines 5633 5636 +3
======================================
+ Hits 5341 5345 +4
+ Misses 292 291 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The goal of this pull request is to generalize SparseDimPartitioner into more scenarios, to support: