Update AMReX and pyAMReX dependencies. #760
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I seem to recall that we previously had problems on Windows with FFTW libraries related to the 1D FFT that Alex was using for the CSR solve, which were avoided when Alex switched from using FFTW to anyfft. |
cemitch99
commented
Dec 5, 2024
| #else() | ||
| # set(AMReX_FFT OFF CACHE INTERNAL "") | ||
| #endif() | ||
|
|
There was a problem hiding this comment.
This is a commented duplicate of 40-44, because I wasn't sure of the best place to put this.
cemitch99
commented
Dec 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AMReX, ABLASTR, pyAMReX dependencies to the latest development, to use updated WarpX IGF solver exploiting new AMReX FFT: ECP-WarpX/WarpX#5457