i#7046 Add Linux support to dr_create_memory_dump. #7047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivankyluk
force-pushed
the
i7046-add-linux-support-to-dr_create_memory_dump
branch
from
a6cee2c to
f37ddc3
Compare
ivankyluk
changed the title
ivankyluk
force-pushed
the
i7046-add-linux-support-to-dr_create_memory_dump
branch
2 times, most recently
from
1c8c659 to
971b2d1
Compare
ivankyluk
changed the title
ivankyluk
force-pushed
the
i7046-add-linux-support-to-dr_create_memory_dump
branch
5 times, most recently
from
39dcddf to
05727e4
Compare
ivankyluk
force-pushed
the
i7046-add-linux-support-to-dr_create_memory_dump
branch
from
05727e4 to
37f8abf
Compare
|
Sorry for the delay: I missed this. Please ping earlier in the future. |
Please don't force-push on shared branches (documented at https://dynamorio.org/page_code_reviews.html#autotoc_md118 and in other places) |
|
I've pull a new request #7053. |
Is that b/c of the force pushes? Probably not necessary; if anyone had pulled the branch (not likely) the damage is already done; avoiding future ones will avoid review issues now that reviewing has started. |
…. Add suite/tests/CMakeLists.txt which was missed in the last commit. Use synch_with_all_threads instead of dr_suspend_all_other_threads_ex.
derekbruening
approved these changes
Nov 7, 2024
ivankyluk
deleted the
i7046-add-linux-support-to-dr_create_memory_dump
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first change to add Linux support to dr_create_memory_dump. The memory dump is written in ELF format and saved under the logs directory following the Windows example in win32/os.c.
Add a new test, memory_dump_test, to test dr_create_memory_dump for X64 Linux.
Issue: #7046