Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6529: Check end of section headers mapped #6531

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

derekbruening
Copy link
Contributor

Updates the rseq_process_module() check for the section headers being in the mapped region to check the endpoint instead of the start point.

Tested locally: now client.drwrap-test passes when it failed with the toolchain on my local machine.

Fixes #6529

Updates the rseq_process_module() check for the section headers being
in the mapped region to check the endpoint instead of the start point.

Tested locally: now client.drwrap-test passes when it failed with the
toolchain on my local machine.

Fixes #6529
@derekbruening
Copy link
Contributor Author

Failure is the new client.detach_test which seems to be flaky. I filed #6536.

core/unix/rseq_linux.c Outdated Show resolved Hide resolved
@derekbruening
Copy link
Contributor Author

x64 failure is attach_test flake #6452

@derekbruening derekbruening merged commit 1e37940 into master Jan 2, 2024
13 of 15 checks passed
@derekbruening derekbruening deleted the i6529-rseq-sec-end branch January 2, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRASH drwrap-test: rseq_process_module incorrectly thinks section headers are mapped in
2 participants