#96 Fix picking camera image without cropping #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Drjacky Can you please let know when this changes will be merged in the source. Changes looks correct for me. |
Drjacky
reviewed
Aug 3, 2023
| @@ -140,7 +140,7 @@ class MainActivity : AppCompatActivity() { | |||
| fun pickCameraImage(view: View) { | |||
| cameraLauncher.launch( | |||
| ImagePicker.with(this) | |||
| .crop() | |||
| //.crop() | |||
There was a problem hiding this comment.
Okay, I see that's because of #96
There was a problem hiding this comment.
but what if someone wants to crop the camera image?
There was a problem hiding this comment.
There is no problem. It's optional. Both with or without crop are handled.
There was a problem hiding this comment.
So, the issue is not with the crop itself as the titles say: #96 Fix picking camera image without cropping & [Crash] When picking a camera image without setting crop()
The improvement is here, right?
mImageUri?.path?.let { path ->
File(path).delete()
}
it.delete() //Why uncommented BTW?
Drjacky
reviewed
Aug 3, 2023
| mImageUri?.path?.let { path -> | ||
| File(path).delete() | ||
| } | ||
| it.delete() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied changes below: