Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Warnings for Commas After Conditional Directives #3839

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Skip Warnings for Commas After Conditional Directives #3839

wants to merge 8 commits into from

Conversation

MattFromRVA
Copy link
Contributor

Fixes #3816

@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.01980% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.45%. Comparing base (17b613d) to head (f8a89a2).
Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
+ Coverage   94.38%   97.45%   +3.07%     
==========================================
  Files         925      926       +1     
  Lines      110065   110337     +272     
  Branches     3307     3317      +10     
==========================================
+ Hits       103881   107531    +3650     
+ Misses       5174     1838    -3336     
+ Partials     1010      968      -42

@MattFromRVA MattFromRVA changed the title Do not warn if a comma follows a preprocessor directive Skip Warnings for Commas After Conditional Directives May 15, 2024
@MattFromRVA
Copy link
Contributor Author

Thanks for the feedback @bjornhellander! My changes are ready for review. I believe the pipeline errors are not related to my code changes?

bjornhellander
bjornhellander approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@bjornhellander bjornhellander left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. And no, the failing tests do not look like your fault.

@bjornhellander
Copy link
Contributor

@sharwell, do you have any additional comments?

@sharwell
Copy link
Member

Two small things to update but otherwise looks good.

@MattFromRVA MattFromRVA requested a review from sharwell June 25, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell Awaiting requested review from sharwell

@bjornhellander bjornhellander Awaiting requested review from bjornhellander

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not warn SA1001 (Commas should be spaced correctly) if comma follows a preprocessor directive
3 participants
@MattFromRVA @bjornhellander @sharwell