Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 exactly: set reward asset price to 0 when undefined #1049

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

itofarina
Copy link
Contributor

No description provided.

@llamatester
Copy link

The exactly adapter exports pools:

Test Suites: 1 passed, 1 total
Tests: 296 passed, 296 total
Snapshots: 0 total
Time: 0.496 s
Ran all test suites.

Nb of pools: 44
 

Sample pools:
┌─────────┬────────────┬───────────┬──────────┬────────────────────┬──────────────────────────────────────────────────┬───────────────────────────────┬────────────────────┬──────────────────────────────────────────────────────────────────┬─────────────────────┬────────────────────┬────────────────────┬────────────────────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┬─────────────────────┬────────────────────┬──────────────┐
│ (index) │   chain    │  project  │  symbol  │       tvlUsd       │                 underlyingTokens                 │              url              │        ltv         │                               pool                               │       apyBase       │   apyBaseBorrow    │   totalSupplyUsd   │   totalBorrowUsd   │                                                                 rewardTokens                                                                 │      apyReward      │  apyRewardBorrow   │   poolMeta   │
├─────────┼────────────┼───────────┼──────────┼────────────────────┼──────────────────────────────────────────────────┼───────────────────────────────┼────────────────────┼──────────────────────────────────────────────────────────────────┼─────────────────────┼────────────────────┼────────────────────┼────────────────────┼──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┼─────────────────────┼────────────────────┼──────────────┤
│    0    │ 'optimism' │ 'exactly' │  'USDC'  │ 4296671.2494625915 │ [ '0x7F5c764cBc14f9669B88837ca1490cCa17c31607' ] │  'https://app.exact.ly/USDC'  │ 0.8281000000000001 │      '0x81c9a7b55a4df39a9b7b5f781ec0e53539694873-optimism'       │ 3.2127998046874717  │ 4.265398181891711  │ 12522158.763693579 │ 8437702.058898112  │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │ 0.9174236710808525  │ 0.8131866075646643 │              │
│    1    │ 'optimism' │ 'exactly' │  'USDC'  │ 4296671.2494625915 │ [ '0x7F5c764cBc14f9669B88837ca1490cCa17c31607' ] │  'https://app.exact.ly/USDC'  │ 0.8281000000000001 │ '0x81c9a7b55a4df39a9b7b5f781ec0e53539694873-optimism-2023-10-26' │ 2.6160414984236935  │  3.28773191091265  │ 2832246.4713422875 │ 368785.61669849895 │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │ 0.8116266878221978 │ '2023-10-26' │
│    2    │ 'optimism' │ 'exactly' │  'USDC'  │ 4296671.2494625915 │ [ '0x7F5c764cBc14f9669B88837ca1490cCa17c31607' ] │  'https://app.exact.ly/USDC'  │ 0.8281000000000001 │ '0x81c9a7b55a4df39a9b7b5f781ec0e53539694873-optimism-2023-11-23' │ 2.1889506387124724  │ 3.026192796415117  │ 2832242.0296260086 │ 236796.42696209496 │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │ 0.8130858452372491 │ '2023-11-23' │
│    3    │ 'optimism' │ 'exactly' │  'USDC'  │ 4296671.2494625915 │ [ '0x7F5c764cBc14f9669B88837ca1490cCa17c31607' ] │  'https://app.exact.ly/USDC'  │ 0.8281000000000001 │ '0x81c9a7b55a4df39a9b7b5f781ec0e53539694873-optimism-2023-12-21' │  2.56650533296503   │ 3.7873479250203568 │ 2832240.928526009  │ 581328.4079462859  │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │ 0.8131387642450472 │ '2023-12-21' │
│    4    │ 'optimism' │ 'exactly' │  'USDC'  │ 4296671.2494625915 │ [ '0x7F5c764cBc14f9669B88837ca1490cCa17c31607' ] │  'https://app.exact.ly/USDC'  │ 0.8281000000000001 │ '0x81c9a7b55a4df39a9b7b5f781ec0e53539694873-optimism-2024-01-18' │ 2.5012140419642392  │ 3.485591796426468  │ 2832240.8284260086 │  447030.121954416  │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │ 0.8131572673323317 │ '2024-01-18' │
│    5    │ 'optimism' │ 'exactly' │  'USDC'  │ 4296671.2494625915 │ [ '0x7F5c764cBc14f9669B88837ca1490cCa17c31607' ] │  'https://app.exact.ly/USDC'  │ 0.8281000000000001 │ '0x81c9a7b55a4df39a9b7b5f781ec0e53539694873-optimism-2024-02-15' │ 2.5485904310535545  │ 3.5947916291302118 │ 2832240.8284260086 │ 495866.37100500497 │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │ 0.8131666897382539 │ '2024-02-15' │
│    6    │ 'optimism' │ 'exactly' │  'USDC'  │ 4296671.2494625915 │ [ '0x7F5c764cBc14f9669B88837ca1490cCa17c31607' ] │  'https://app.exact.ly/USDC'  │ 0.8281000000000001 │ '0x81c9a7b55a4df39a9b7b5f781ec0e53539694873-optimism-2024-03-14' │  2.078794737610412  │ 3.4108064942702354 │ 2832240.8284260086 │  413154.038812515  │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │ 0.8131723990722151 │ '2024-03-14' │
│    7    │ 'optimism' │ 'exactly' │ 'wstETH' │ 3732250.7442724463 │ [ '0x1F32b1c2345538c0c6f582fCB022739c4A194Ebb' ] │ 'https://app.exact.ly/wstETH' │ 0.6723999999999999 │      '0x22ab31cd55130435b5efbf9224b6a9d5ec36533f-optimism'       │ 0.01817036869977695 │ 1.7778605746371134 │ 3755476.0117887673 │ 23887.391491377126 │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │ 0.46784047575809673 │     undefined      │              │
│    8    │ 'optimism' │ 'exactly' │ 'wstETH' │ 3732250.7442724463 │ [ '0x1F32b1c2345538c0c6f582fCB022739c4A194Ebb' ] │ 'https://app.exact.ly/wstETH' │ 0.6723999999999999 │ '0x22ab31cd55130435b5efbf9224b6a9d5ec36533f-optimism-2023-10-26' │          0          │ 2.2133619434977714 │ 3356041.1579642044 │         0          │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │     undefined      │ '2023-10-26' │
│    9    │ 'optimism' │ 'exactly' │ 'wstETH' │ 3732250.7442724463 │ [ '0x1F32b1c2345538c0c6f582fCB022739c4A194Ebb' ] │ 'https://app.exact.ly/wstETH' │ 0.6723999999999999 │ '0x22ab31cd55130435b5efbf9224b6a9d5ec36533f-optimism-2023-11-23' │          0          │ 2.2242341567746404 │ 3356041.019118513  │         0          │ [ '0x4200000000000000000000000000000000000042', '0x1e925De1c68ef83bD98eE3E130eF14a50309C01B', '0xbea586A167853ADddEF12818f264f1F9823fBc18' ] │                     │     undefined      │ '2023-11-23' │
└─────────┴────────────┴───────────┴──────────┴────────────────────┴──────────────────────────────────────────────────┴───────────────────────────────┴────────────────────┴──────────────────────────────────────────────────────────────────┴─────────────────────┴────────────────────┴────────────────────┴────────────────────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┴─────────────────────┴────────────────────┴──────────────┘
This adapter contains some pools with <10k TVL, these pools won't be shown in DefiLlama

@slasher125 slasher125 merged commit ede3bf4 into DefiLlama:master Oct 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants