Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable transparent hugepage at boot #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

awr
Copy link
Contributor

@awr awr commented Mar 10, 2017

As another version of #103 which includes updates to init.d

@btd
Copy link

btd commented Mar 26, 2017

I think this is 👍 change.
Probably in future this could be a separate role, others could reuse it - it looks written in pretty reusable way.

@awr
Copy link
Contributor Author

awr commented Mar 28, 2017

good point @btd . I'll take a stab at pulling it out later this week.

@awr
Copy link
Contributor Author

awr commented Mar 29, 2017

Ok, I've put together https://github.com/NudgeSoftware/ansible-transparent-huge-pages
Note that there's also this one: https://github.com/SimpliField/ansible-transparent-huge-pages, which I discovered afterwards ...

@btd
Copy link

btd commented Mar 30, 2017

@awr, i think you need to add start before in systemd unit files.
In [Unit] section, it is possible to add Before and Wants directives. Also github show strange line endings in your tasks\main.yml.

{% for service in start_before %}
Wants={{ service }}
Before={{ service }}
{% endfor %}

Also can you please add it to galaxy

@btd
Copy link

btd commented Mar 30, 2017

@awr just fyi, to make it work at ubuntu 16.04, i did small changes:

[Unit]
Description=Disable Transparent Huge Pages

Before=redis-server.service
Wants=redis-server.service

[Service]
Type=oneshot
ExecStart=/bin/sh -c "/bin/echo never > /sys/kernel/mm/transparent_hugepage/enabled"
ExecStart=/bin/sh -c "/bin/echo never > /sys/kernel/mm/transparent_hugepage/defrag"

[Install]
WantedBy=multi-user.target

@awr
Copy link
Contributor Author

awr commented Mar 31, 2017

Thanks for the suggestions @btd -- I've added them in here: NudgeSoftware/ansible-transparent-huge-pages@c8d3e97

As for adding to galaxy, I realized that I'd have to authorize my company's org (which I'm not able to at this time). If you want it on galaxy please feel free to fork it and push it up from your fork.

@DavidWittman
Copy link
Owner

@awr Sorry for the slow feedback. I think I'm going to implement this as a role dependency, which will require pushing it up to Galaxy. If you haven't got authorization from your org I can fork and take care of that part.

@awr
Copy link
Contributor Author

awr commented Apr 17, 2017

No worries -- yeah, I unfortunately can't. Please fork for me if you're willing!

@DavidWittman DavidWittman added this to the 2.0 milestone May 13, 2017
@sensei100
Copy link

Are there still plans to merge this PR at some point?

@tanji
Copy link

tanji commented Dec 5, 2022

Hello,
please consider merging this as for many users it will cause Redis to have performance issues...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants