Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/gomodule/redigo: adds the DialURLContext method #3016

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Succo
Copy link

@Succo Succo commented Dec 6, 2024

Matches what the redigo package provides.
Also rewrite non context variant of dialer to use Context equivalent with context.Background

What does this PR do?

Matches what the redigo package provides.
Also rewrite non context variant of dialer to use Context equivalent with context.Background

Motivation

Matches what the redigo package provides is done so that DialURL can propagates the caller context.

Also rewrite non context variant of dialer to use Context equivalent with context.Background is done to reduce duplication in code and ensure switching to the Context aware variant has no side effect.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

Matches what the redigo package provides.
Also rewrite non context variant of dialer to use Context equivalent
with context.Background
@Succo Succo requested review from a team as code owners December 6, 2024 11:20
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting on @DataDog/apm-idm-go approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants