Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry: submit orchestrion_usage counter metric #3015

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

RomainMuller
Copy link
Contributor

What does this PR do?

To make it easier to get data about orchestrion usage, start submitting a counter metric in telemetry for applications built with orchestrion.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

To make it easier to get data about orchestrion usage, start submitting
a counter metric in telemetry for applications built with orchestrion.
@RomainMuller RomainMuller requested review from a team as code owners December 6, 2024 10:46
@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2024

Benchmarks

Benchmark execution time: 2024-12-09 13:59:49

Comparing candidate commit 78e6f39 in PR branch romain.marcadier/orchestrion-telemetry-metric with baseline commit 79a1f60 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics.

scenario:BenchmarkHttpServeTrace-24

  • 🟥 execution_time [+501.108ns; +559.092ns] or [+3.183%; +3.551%]

@RomainMuller RomainMuller marked this pull request as draft December 6, 2024 12:44
ddtrace/tracer/telemetry.go Outdated Show resolved Hide resolved
@RomainMuller RomainMuller force-pushed the romain.marcadier/orchestrion-telemetry-metric branch from f3a5dec to 79e9f93 Compare December 9, 2024 12:28
@RomainMuller RomainMuller force-pushed the romain.marcadier/orchestrion-telemetry-metric branch from 77f1f56 to 78e6f39 Compare December 9, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants