Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flaky SpanSampler limiter test #61

Merged
1 commit merged into from
Oct 17, 2023
Merged

fix flaky SpanSampler limiter test #61

1 commit merged into from
Oct 17, 2023

Conversation

dgoffredo
Copy link
Contributor

... by not using the real clock. Mock the clock.

@dgoffredo dgoffredo requested a review from cgilmour October 12, 2023 19:13
@pr-commenter
Copy link

pr-commenter bot commented Oct 12, 2023

Benchmarks

Benchmark execution time: 2023-10-12 19:15:12

Comparing candidate commit 03a9921 in PR branch david.goffredo/fix-flaky-limiter-test with baseline commit 45c3c05 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@cgilmour cgilmour mentioned this pull request Oct 13, 2023
Merged
dmehala
dmehala approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@dmehala dmehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cgilmour cgilmour closed this pull request by merging all changes into main in fd23d07 Oct 17, 2023
@cgilmour cgilmour deleted the david.goffredo/fix-flaky-limiter-test branch October 17, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmehala dmehala dmehala approved these changes

@cgilmour cgilmour Awaiting requested review from cgilmour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgoffredo @dmehala @cgilmour