patch some build/test scripts in bin/
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow it's already been 3 weeks. My apologies @dgoffredo. I recently updated CMakeLists.txt, can you try without the changes on |
dgoffredo
force-pushed
the
david.goffredo/patch-system-tests-build
branch
from
fab2d36 to
5ce5830
Compare
|
I force pushed an update that removes the CMake changes and rebases onto Keep in mind that the branch name "patch-system-tests-build" is now a misnomer, since this doesn't patch the system tests build anymore. |
dmehala
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just set up VSCode's clangd extension for C++ source browsing, and was giving it a test drive in dd-trace-cpp.
bin/testwas failing on my machine due to changes needed in the build configuration oftest/system-tests, andbin/checkwas failing due to changes needed tobin/bazel-build. At least on my machine.If some of the helper scripts in
bin/are no longer in use, it might be best to delete them. For now, I propose these changes to get things working again locally on my machine.