Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] gpu: auto-enable agent-size check if system-probe gpu_monitoring module is enabled #32521

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gjulianm
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm self-assigned this Dec 26, 2024
@github-actions github-actions bot added team/agent-shared-components short review PR is simple enough to be reviewed quickly labels Dec 26, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51806948 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor f8e543c61fa2c97e54a0505062b790d56722bc04

Diff per package
package diff status size ancestor threshold
datadog-heroku-agent-amd64-deb 1.40MB ⚠️ 506.61MB 505.21MB 70.00MB
datadog-agent-aarch64-rpm 1.40MB ⚠️ 945.75MB 944.35MB 140.00MB
datadog-agent-arm64-deb 1.40MB ⚠️ 936.48MB 935.08MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1200.09MB 1200.09MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1200.09MB 1200.09MB 140.00MB
datadog-agent-amd64-deb 0.00MB 1190.80MB 1190.80MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.42MB 113.42MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.42MB 113.42MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: da9ee2d7-7cb8-4b22-bfb3-27ccde3cf647

Baseline: f8e543c
Comparison: 1db0904
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +0.91 [-2.30, +4.13] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.74 [+0.06, +1.43] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.66 [+0.60, +0.73] 1 Logs
quality_gate_idle_all_features memory utilization +0.15 [+0.07, +0.23] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.68, +0.78] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.73, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.61, +0.67] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.86, +0.90] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.85, +0.83] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.11] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.01 [-0.84, +0.81] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.02 [-0.48, +0.45] 1 Logs
file_tree memory utilization -0.21 [-0.35, -0.08] 1 Logs
quality_gate_idle memory utilization -0.46 [-0.50, -0.42] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.63 [-1.42, +0.15] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
short review PR is simple enough to be reviewed quickly team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant