Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record log content bytes from TCP / UDP #32517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keisku
Copy link
Contributor

@keisku keisku commented Dec 26, 2024

What does this PR do?

Record log content bytes from TCP / UDP.

Motivation

"Bytes Read" is not counted.

Describe how you validated your changes

docker run --name datadog-agent -d --cgroupns host --pid host \
-v /var/run/docker.sock:/var/run/docker.sock:ro \
-v /proc/:/host/proc/:ro -v /sys/fs/cgroup/:/host/sys/fs/cgroup:ro \
-e DD_API_KEY=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx \
-e DD_LOG_LEVEL=debug \
-e DD_LOGS_ENABLED=true \
$(docker build -t datadog-agent --quiet -<<-EOD
FROM datadog/agent-dev:keisku-logs-agent-status-bytes-read-py3
COPY --chmod=755 <<conf.yaml /etc/datadog-agent/conf.d/logger.d/
logs:
- type: udp
  port: 10514
  service: udp-logger
  source: python
conf.yaml
COPY --chmod=755 <<logger.py /opt/datadog-agent/scripts/
import socket
import time

UDP_PORT = 10514

while True:
    with socket.socket(socket.AF_INET, socket.SOCK_DGRAM) as s:
        s.sendto(b"hello", ("127.0.0.1", UDP_PORT))
    time.sleep(5)
logger.py
EOD
)


docker exec -it datadog-agent /opt/datadog-agent/embedded/bin/python /opt/datadog-agent/scripts/logger.py

docker exec -it datadog-agent agent status
....
==========
Logs Agent
==========

    Reliable: Sending compressed logs in HTTPS to agent-http-intake.logs.datadoghq.com on port 443
    BytesSent: 789447
    EncodedBytesSent: 111629
    LogsProcessed: 3
    LogsSent: 12
    RetryCount: 0
    RetryTimeSpent: 0s
    CoreAgentProcessOpenFiles: 38
    OSFileLimit: 1048576
  ============
  Integrations
  ============

  logger
  ------
    - Type: udp
      Port: 10514
      Service: udp-logger
      Source: python
      Status: OK  
      Bytes Read: 15   <-------------- Counted!
      Pipeline Latency:
        Average Latency (ms): 0
        24h Average Latency (ms): 0
        Peak Latency (ms): 0
        24h Peak Latency (ms): 0

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/agent-metrics-logs short review PR is simple enough to be reviewed quickly labels Dec 26, 2024
@keisku keisku added this to the 7.62.0 milestone Dec 26, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 26, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51802466 --os-family=ubuntu

Note: This applies to commit 917748a

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 26, 2024

Uncompressed package size comparison

Comparison with ancestor 701ea4a893ea0f2fd137f9ac0efad01ce158f55f

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.02MB ⚠️ 1200.08MB 1200.07MB 140.00MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 1200.08MB 1200.07MB 140.00MB
datadog-agent-amd64-deb 0.02MB ⚠️ 1190.79MB 1190.77MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.42MB 113.42MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.42MB 113.42MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.35MB 113.35MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.21MB 505.21MB 70.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm -0.00MB 108.88MB 108.88MB 10.00MB
datadog-agent-aarch64-rpm -0.01MB 944.36MB 944.37MB 140.00MB
datadog-agent-arm64-deb -0.01MB 935.09MB 935.10MB 140.00MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 906682cd-764e-4644-ae94-334db2d69642

Baseline: 701ea4a
Comparison: 1e55fc0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.79 [+0.10, +1.47] 1 Logs
quality_gate_logs % cpu utilization +0.28 [-2.94, +3.49] 1 Logs
quality_gate_idle_all_features memory utilization +0.17 [+0.09, +0.25] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.11 [+0.07, +0.15] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.68, +0.90] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.09 [-0.77, +0.96] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.09 [-0.70, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.08 [-0.82, +0.98] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.45, +0.47] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.72, +0.73] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.11, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.89, +0.89] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.04 [-0.68, +0.60] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.37 [-0.43, -0.32] 1 Logs
file_tree memory utilization -0.52 [-0.65, -0.39] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@keisku keisku added the qa/done QA done before merge and regressions are covered by tests label Dec 26, 2024
@keisku keisku marked this pull request as ready for review December 26, 2024 08:18
@keisku keisku requested a review from a team as a code owner December 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-metrics-logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant