Revert "fix(notify): Handle case with undefined variable (#32165)"

[CelianR]

This reverts commit e999173.

What does this PR do?

Reverts #32165 because it made the unit tests flakey (example, example)

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

notify

  notify:
    dependencies: []
    image: registry.ddbuild.io/slack-notifier:v27936653-9a2a7db-sdm-gbi-jammy@sha256:c9d1145319d1904fa72ea97904a15200d3cb684324723f9e1700bc02cc85065c
    resource_group: notification
    rules:
    - if: $DEPLOY_AGENT == "true" || $DDR_WORKFLOW_ID != null
      when: always
    - if: $CI_COMMIT_BRANCH == "main"
      when: always
    - if: $CI_COMMIT_BRANCH =~ /^[0-9]+\.[0-9]+\.x$/
      when: always
    script:
    - GITLAB_TOKEN=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $GITLAB_TOKEN read_api)
      || exit $?; export GITLAB_TOKEN
    - DD_API_KEY=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $AGENT_API_KEY_ORG2 token)
      || exit $?; export DD_API_KEY
    - python3 -m pip install -r requirements.txt -r tasks/libs/requirements-notifications.txt
-   - invoke -e notify.send-message -p $CI_PIPELINE_ID
-   - invoke -e notify.check-consistent-failures -p $CI_PIPELINE_ID
+   - "# Do not send notifications if this is a child pipeline of another repo\n# The\
+     \ triggering repo should already have its own notification system\nif [ \"$CI_PIPELINE_SOURCE\"\
+     \ != \"pipeline\" ]; then\n  if [ \"$DEPLOY_AGENT\" = \"true\" ]; then\n    invoke\
+     \ -e notify.send-message --notification-type \"deploy\"\n  elif [ \"$CI_PIPELINE_SOURCE\"\
+     \ != \"push\" ]; then\n    invoke -e notify.send-message --notification-type \"\
+     trigger\"\n  else\n    invoke -e notify.send-message --notification-type \"merge\"\
+     \n  fi\n  if [ \"$CI_COMMIT_BRANCH\" = \"$CI_DEFAULT_BRANCH\" ]; then\n    invoke\
+     \ notify.check-consistent-failures\n  fi\nelse\n  echo \"This pipeline was triggered\
+     \ by another repository, skipping notification.\"\nfi\n"
    stage: notify
    tags:
    - arch:amd64
    timeout: 15 minutes

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ae9995c6-9a76-440b-afc9-4fbee53b6e5a

Baseline: a6860d5
Comparison: 3ae5381
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	file_to_blackhole_300ms_latency	egress throughput	+0.18	[-0.46, +0.83]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.18	[-0.61, +0.97]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.12	[-0.63, +0.86]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.11	[-0.36, +0.58]	1	Logs
➖	quality_gate_idle	memory utilization	+0.10	[+0.05, +0.14]	1	Logs bounds checks dashboard
➖	file_tree	memory utilization	+0.08	[-0.05, +0.20]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.07	[-0.01, +0.16]	1	Logs bounds checks dashboard
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.06	[-0.85, +0.97]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.11, +0.12]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.03	[-0.96, +0.90]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.12	[-0.96, +0.72]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.50	[-1.29, +0.29]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.59	[-0.66, -0.53]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.26	[-1.94, -0.59]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.91	[-5.10, +1.28]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.