Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable otel-to-otel-logs #32467

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Disable otel-to-otel-logs #32467

merged 1 commit into from
Dec 23, 2024

Conversation

blt
Copy link
Contributor

@blt blt commented Dec 23, 2024

What does this PR do?

Disables otel-to-otel-logs experiment.

Motivation

We recognize that this experiment requires an unusual degree of memory to operate -- tens of GiB -- and is not known to be representative. It needs closer examination. Meanwhile it is a source for non-trivial pipeline failures. Best to temporarily disable it and come back to it later.

We recognize that this experiment requires an unusual degree of memory
to operate -- tens of GiB -- and is not known to be representative. It
needs closer examination. Meanwhile it is a source for non-trivial
pipeline failures. Best to temporarily disable it and come back to it
later.

Signed-off-by: Brian L. Troutwine <[email protected]>
@blt blt added changelog/no-changelog team/single-machine-performance Single Machine Performance qa/no-code-change No code change in Agent code requiring validation labels Dec 23, 2024
@blt blt requested a review from a team as a code owner December 23, 2024 16:13
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 23, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 51738199 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 528fb2d2b937037c0874f02d9512c364e697a6f8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 1.41MB ⚠️ 1189.61MB 1188.21MB 140.00MB
datadog-agent-x86_64-rpm 1.41MB ⚠️ 1198.88MB 1197.47MB 140.00MB
datadog-agent-x86_64-suse 1.41MB ⚠️ 1198.88MB 1197.47MB 140.00MB
datadog-agent-aarch64-rpm 1.41MB ⚠️ 944.75MB 943.35MB 140.00MB
datadog-agent-arm64-deb 1.40MB ⚠️ 935.51MB 934.10MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB
datadog-heroku-agent-amd64-deb -1.40MB 505.09MB 506.49MB 70.00MB

Decision

⚠️ Warning

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9454d701-55f2-4588-94fc-98d267019a04

Baseline: 528fb2d
Comparison: 74f6efa
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.54 [-0.71, +5.80] 1 Logs
quality_gate_idle_all_features memory utilization +0.80 [+0.72, +0.89] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.57 [+0.54, +0.61] 1 Logs bounds checks dashboard
file_tree memory utilization +0.23 [+0.10, +0.36] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.88, +0.91] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.13, +0.12] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.75, +0.73] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.90, +0.84] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.04 [-0.95, +0.88] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.06 [-0.70, +0.58] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.08 [-0.15, -0.01] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.13 [-0.91, +0.65] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.23 [-0.69, +0.23] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.45 [-1.23, +0.33] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.93 [-2.62, -1.24] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@blt
Copy link
Contributor Author

blt commented Dec 23, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 23, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-23 23:24:46 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2024-12-23 23:59:48 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit a6860d5 into main Dec 23, 2024
244 checks passed
@dd-mergequeue dd-mergequeue bot deleted the blt/disable_otel-to-otel-logs branch December 23, 2024 23:59
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 24, 2024
louis-cqrl pushed a commit that referenced this pull request Dec 25, 2024
Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/single-machine-performance Single Machine Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants