Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTP zstd compression for the Agent telemetry payloads #32440

Merged
merged 5 commits into from
Dec 25, 2024

Conversation

iglendd
Copy link
Contributor

@iglendd iglendd commented Dec 21, 2024

What does this PR do?

Adds compression to Agent telemetry payloads

Motivation

Decrease network utilization

Describe how you validated your changes

Add TestUsingGZipCompressionInAgentTelemetrySender unit test

Possible Drawbacks / Trade-offs

Additional Notes

Small payloads ~600 bytes decreased by 2x+, medium payloads ~3k are decreased by ~6x

@github-actions github-actions bot added team/agent-shared-components short review PR is simple enough to be reviewed quickly labels Dec 21, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 21, 2024

Uncompressed package size comparison

Comparison with ancestor 8f37b9b9400d08e35dc4e1120b6a5603cba2f084

Diff per package
package diff status size ancestor threshold
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.42MB 113.42MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.42MB 113.42MB 10.00MB
datadog-agent-amd64-deb 0.00MB 1190.77MB 1190.77MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1200.07MB 1200.07MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1200.07MB 1200.07MB 140.00MB
datadog-agent-arm64-deb 0.00MB 935.10MB 935.10MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 944.37MB 944.37MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.21MB 505.21MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 21, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51796455 --os-family=ubuntu

Note: This applies to commit 2a1fca2

Copy link

cit-pr-commenter bot commented Dec 21, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 81882347-8e7f-43ef-aaf7-069a960fdd86

Baseline: 8f37b9b
Comparison: 2a1fca2
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.14 [+1.06, +1.21] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.21 [-0.57, +0.98] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.17 [-0.30, +0.63] 1 Logs
quality_gate_idle_all_features memory utilization +0.15 [+0.07, +0.24] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.04 [+0.01, +0.08] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.69, +0.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.02 [-0.63, +0.67] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.10] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.79, +0.78] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.89, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.83, +0.81] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.07 [-0.90, +0.75] 1 Logs
file_tree memory utilization -0.15 [-0.28, -0.02] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.79 [-1.47, -0.10] 1 Logs
quality_gate_logs % cpu utilization -1.31 [-4.55, +1.94] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@iglendd iglendd force-pushed the len.gamburg/agent-tel-gzip branch 2 times, most recently from f141af8 to 8e3e26e Compare December 24, 2024 01:36
@github-actions github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Dec 24, 2024
@iglendd iglendd force-pushed the len.gamburg/agent-tel-gzip branch from 8e3e26e to e6aff9b Compare December 24, 2024 01:39
@iglendd iglendd added this to the 7.63.0 milestone Dec 24, 2024
@iglendd iglendd added the qa/done QA done before merge and regressions are covered by tests label Dec 24, 2024
@iglendd iglendd marked this pull request as ready for review December 24, 2024 01:42
@iglendd iglendd requested review from a team as code owners December 24, 2024 01:42
@iglendd iglendd requested a review from ogaca-dd December 24, 2024 01:42
@louis-cqrl louis-cqrl removed the request for review from ogaca-dd December 24, 2024 12:45
@iglendd
Copy link
Contributor Author

iglendd commented Dec 25, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 25, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-25 20:02:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-25 20:59:11 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.


2024-12-25 21:35:12 UTC ℹ️ MergeQueue: This merge request was merged

@iglendd iglendd changed the title Use HTTP gzip compression for the Agent telemetry payloads Use HTTP zstd compression for the Agent telemetry payloads Dec 25, 2024
@dd-mergequeue dd-mergequeue bot merged commit 701ea4a into main Dec 25, 2024
222 checks passed
@dd-mergequeue dd-mergequeue bot deleted the len.gamburg/agent-tel-gzip branch December 25, 2024 21:35
@github-actions github-actions bot removed this from the 7.63.0 milestone Dec 25, 2024
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants