Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bump github.com/DataDog/go-sqllexer to v0.0.18" #32365

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

KSerrania
Copy link
Contributor

What does this PR do?

Reverts #32315.

Motivation

This PR broke a KMT test (pkg/network/protocols/postgres.TestExtractTableFunction/single_table_name_with_mixed_caps).

#incident-33427

@KSerrania KSerrania added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 18, 2024
@KSerrania KSerrania marked this pull request as ready for review December 18, 2024 20:35
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Dec 18, 2024
@KSerrania
Copy link
Contributor Author

Force-merging the PR to fix main

@KSerrania KSerrania merged commit f803a52 into main Dec 18, 2024
67 of 71 checks passed
@KSerrania KSerrania deleted the revert-32315-zhengda.lu/lexer branch December 18, 2024 20:38
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 18, 2024
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c8167b4d-bf6b-475f-b759-06e9cbcb2265

Baseline: 23a0380
Comparison: 150f46d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.93 [-1.30, +5.16] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +1.30 [+0.62, +1.98] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.35, +0.48] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.23 [-0.58, +1.04] 1 Logs
quality_gate_idle_all_features memory utilization +0.22 [+0.13, +0.30] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.20 [-0.49, +0.89] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.16 [-0.56, +0.88] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.12 [-0.53, +0.76] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.09 [-0.68, +0.87] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.01 [-0.86, +0.88] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.89, +0.88] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.01 [-0.48, +0.46] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.13, +0.10] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.85, +0.80] 1 Logs
quality_gate_idle memory utilization -0.21 [-0.25, -0.18] 1 Logs bounds checks dashboard
file_tree memory utilization -0.58 [-0.72, -0.45] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle_all_features memory_usage 7/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 7/10 replicas passed. Failed 3 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant