Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes_admission_events): flush events after emitting them #32242

Merged

Conversation

wdhif
Copy link
Member

@wdhif wdhif commented Dec 16, 2024

What does this PR do?

Fix the Kubernetes Admission Events unit tests by flushing events after emission instead of before.

Motivation

This is to avoid the flaky Kubernetes Admission Events unit tests.

Describe how you validated your changes

Validated by unit tests.

Possible Drawbacks / Trade-offs

N/A

Additional Notes

@wdhif wdhif added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Dec 16, 2024
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Dec 16, 2024
@wdhif wdhif force-pushed the CONTP-536/wassim.dhif/kubernetes_admission_events branch 2 times, most recently from fb933dc to 2206361 Compare December 16, 2024 17:08
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

[Fast Unit Tests Report]

On pipeline 51737104 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

Uncompressed package size comparison

Comparison with ancestor 528fb2d2b937037c0874f02d9512c364e697a6f8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 1.41MB ⚠️ 1189.61MB 1188.21MB 140.00MB
datadog-agent-x86_64-rpm 1.41MB ⚠️ 1198.88MB 1197.47MB 140.00MB
datadog-agent-x86_64-suse 1.41MB ⚠️ 1198.88MB 1197.47MB 140.00MB
datadog-agent-aarch64-rpm 1.41MB ⚠️ 944.75MB 943.35MB 140.00MB
datadog-agent-arm64-deb 1.40MB ⚠️ 935.51MB 934.10MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB
datadog-heroku-agent-amd64-deb -1.40MB 505.09MB 506.49MB 70.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51737104 --os-family=ubuntu

Note: This applies to commit 673ab1a

@wdhif wdhif force-pushed the CONTP-536/wassim.dhif/kubernetes_admission_events branch from 2206361 to 673ab1a Compare December 23, 2024 15:52
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 11f50b9d-43ce-4623-a735-aad7f763be70

Baseline: 528fb2d
Comparison: 673ab1a
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +1.18 [+0.48, +1.89] 1 Logs
quality_gate_idle_all_features memory utilization +0.64 [+0.55, +0.73] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.52 [-0.17, +1.22] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.36 [+0.30, +0.43] 1 Logs
file_tree memory utilization +0.08 [-0.05, +0.21] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.08 [-0.70, +0.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.73, +0.82] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.03 [-0.44, +0.49] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.89, +0.93] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.12, +0.11] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.00 [-0.65, +0.64] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.02 [-0.89, +0.85] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.96, +0.87] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.45 [-1.24, +0.33] 1 Logs
quality_gate_idle memory utilization -0.53 [-0.58, -0.48] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -4.48 [-7.69, -1.27] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_idle memory_usage 9/10 bounds checks dashboard
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.

@wdhif wdhif marked this pull request as ready for review December 24, 2024 11:44
@wdhif wdhif requested a review from a team as a code owner December 24, 2024 11:44
@wdhif
Copy link
Member Author

wdhif commented Dec 24, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 24, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-24 13:03:06 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-24 13:37:15 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f8da8a4 into main Dec 24, 2024
220 checks passed
@dd-mergequeue dd-mergequeue bot deleted the CONTP-536/wassim.dhif/kubernetes_admission_events branch December 24, 2024 13:37
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants