Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM-3665] Include semodule -l in agent flare #32189

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

pimlu
Copy link
Contributor

@pimlu pimlu commented Dec 16, 2024

What does this PR do?

This PR writes the output of semodule -l into the file system-probe/selinux_semodule_list.log in the Agent flare.

Motivation

Selinux info is useful to resolve customer support cases on distros that use it.

Describe how you validated your changes

Create an agent flare and check for system-probe/selinux_semodule_list.log on an selinux distro e.g. CentOS
Screenshot 2024-12-16 at 10 35 24 AM

Possible Drawbacks / Trade-offs

Additional Notes

@pimlu pimlu added the qa/done QA done before merge and regressions are covered by tests label Dec 16, 2024
@pimlu pimlu added this to the 7.62.0 milestone Dec 16, 2024
@github-actions github-actions bot added the medium review PR review might take time label Dec 16, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

Uncompressed package size comparison

Comparison with ancestor 6f5f2b0e65208a732d6ccb60d2558ebd00e9eda8

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.01MB ⚠️ 1278.10MB 1278.09MB 140.00MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 1278.10MB 1278.09MB 140.00MB
datadog-agent-amd64-deb 0.01MB ⚠️ 1268.87MB 1268.86MB 140.00MB
datadog-heroku-agent-amd64-deb 0.01MB ⚠️ 505.43MB 505.42MB 70.00MB
datadog-iot-agent-aarch64-rpm 0.00MB ⚠️ 108.83MB 108.83MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.52MB 78.52MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.59MB 78.59MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.74MB 55.74MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.28MB 113.28MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.76MB 108.76MB 10.00MB
datadog-iot-agent-x86_64-rpm -0.00MB 113.35MB 113.35MB 10.00MB
datadog-iot-agent-x86_64-suse -0.00MB 113.35MB 113.35MB 10.00MB
datadog-agent-arm64-deb -0.02MB 1003.94MB 1003.96MB 140.00MB
datadog-agent-aarch64-rpm -0.02MB 1013.16MB 1013.17MB 140.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 16, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51237927 --os-family=ubuntu

Note: This applies to commit b6d6cbf

Copy link

cit-pr-commenter bot commented Dec 16, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a7c6f791-b27f-406e-96d9-e32635fc6085

Baseline: 6f5f2b0
Comparison: b6d6cbf
Diff

❌ Experiments with missing or malformed data

This is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.

  • uds_dogstatsd_to_api_cpu (Logs)

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.87 [+0.73, +1.00] 1 Logs
otel_to_otel_logs ingress throughput +0.63 [-0.04, +1.29] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.06 [-0.40, +0.51] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.05 [-0.79, +0.88] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.83, +0.87] 1 Logs
quality_gate_idle_all_features memory utilization +0.01 [-0.11, +0.12] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.73, +0.73] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.78, +0.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.63, +0.62] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.82, +0.80] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
quality_gate_idle memory utilization -0.07 [-0.12, -0.02] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -0.29 [-3.22, +2.63] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.54 [-1.32, +0.25] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.84 [-0.90, -0.78] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency_http1 lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@pimlu pimlu marked this pull request as ready for review December 16, 2024 15:36
@pimlu pimlu requested review from a team as code owners December 16, 2024 15:36
@pimlu pimlu requested a review from jeremy-hanna December 16, 2024 15:36
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor suggestion from Docs and approved the PR.

Copy link
Contributor

@jeremy-hanna jeremy-hanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for ASC owned files

@pimlu
Copy link
Contributor Author

pimlu commented Dec 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 18, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-18 22:18:58 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 28m.


2024-12-18 22:44:13 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit f51b26c into main Dec 18, 2024
302 checks passed
@dd-mergequeue dd-mergequeue bot deleted the stuart.geipel/flare-semodule-list branch December 18, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants