Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a PR to auto bump windows gitlab runner version on every new RC #31971

Merged
merged 27 commits into from
Dec 24, 2024

Conversation

Pythyu
Copy link
Contributor

@Pythyu Pythyu commented Dec 10, 2024

What does this PR do?

Add a new job generate_windows_gitlab_runner_bump_pr which depends on trigger_auto_staging_release to generate a workflow on buildenv repository to bump windows runner agent version.

Motivation

RFC

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@Pythyu
Copy link
Contributor Author

Pythyu commented Dec 10, 2024

Finishing QA before marking it as ready

@github-actions github-actions bot added team/agent-devx-infra medium review PR review might take time labels Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

Gitlab CI Configuration Changes

Added Jobs

.setup_github_app_agent_platform_auto_pr
.setup_github_app_agent_platform_auto_pr:
- 'GITHUB_KEY_B64=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $MACOS_GITHUB_APP_2 key_b64)
  || exit $?; export GITHUB_KEY_B64

  GITHUB_APP_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $MACOS_GITHUB_APP_2 app_id)
  || exit $?; export GITHUB_APP_ID

  GITHUB_INSTALLATION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $MACOS_GITHUB_APP_2
  installation_id) || exit $?; export GITHUB_INSTALLATION_ID

  echo "Using GitHub App instance 2"

  '
generate_windows_gitlab_runner_bump_pr
generate_windows_gitlab_runner_bump_pr:
  image: registry.ddbuild.io/slack-notifier:v27936653-9a2a7db-sdm-gbi-jammy@sha256:c9d1145319d1904fa72ea97904a15200d3cb684324723f9e1700bc02cc85065c
  needs:
  - trigger_auto_staging_release
  rules:
  - if: $DDR == "true"
    when: never
  - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+-v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+){0,1}$/
    when: never
  - if: $CI_COMMIT_TAG =~ /^[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$/
  script:
  - 'GITHUB_KEY_B64=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $MACOS_GITHUB_APP_2
    key_b64) || exit $?; export GITHUB_KEY_B64

    GITHUB_APP_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $MACOS_GITHUB_APP_2 app_id)
    || exit $?; export GITHUB_APP_ID

    GITHUB_INSTALLATION_ID=$($CI_PROJECT_DIR/tools/ci/fetch_secret.sh $MACOS_GITHUB_APP_2
    installation_id) || exit $?; export GITHUB_INSTALLATION_ID

    echo "Using GitHub App instance 2"

    '
  - python3 -m pip install -r requirements.txt -r tasks/libs/requirements-notifications.txt
  - $S3_CP_CMD $S3_ARTIFACTS_URI/agent-version.cache .
  - inv -e github.update-windows-runner-version
  stage: trigger_release
  tags:
  - arch:amd64

Changes Summary

Removed Modified Added Renamed
0 0 2 0

ℹ️ Diff available in the job log.

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

[Fast Unit Tests Report]

On pipeline 51770636 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Dec 10, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1d87324e-b8ef-4600-9439-19a08b1da2d8

Baseline: dbadf91
Comparison: 0996f93
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.25 [+0.22, +0.29] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.15 [-0.31, +0.62] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.75, +0.81] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.87, +0.92] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.01 [-0.93, +0.96] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.11, +0.13] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.02, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.77, +0.76] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.04 [-0.90, +0.81] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.27 [-0.98, +0.44] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.27 [-1.04, +0.50] 1 Logs
quality_gate_logs % cpu utilization -0.30 [-3.45, +2.85] 1 Logs
quality_gate_idle_all_features memory utilization -0.39 [-0.48, -0.30] 1 Logs bounds checks dashboard
file_tree memory utilization -0.41 [-0.55, -0.28] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.90 [-0.97, -0.84] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@Pythyu Pythyu marked this pull request as ready for review December 24, 2024 11:13
@Pythyu Pythyu requested review from a team as code owners December 24, 2024 11:13
@Pythyu Pythyu added the qa/no-code-change No code change in Agent code requiring validation label Dec 24, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 24, 2024

Uncompressed package size comparison

Comparison with ancestor dbadf918107b26e1733db87a51801f0f79893ff8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 1190.70MB 1190.70MB 140.00MB
datadog-agent-x86_64-rpm 0.00MB 1199.96MB 1199.96MB 140.00MB
datadog-agent-x86_64-suse 0.00MB 1199.96MB 1199.96MB 140.00MB
datadog-agent-arm64-deb 0.00MB 934.99MB 934.99MB 140.00MB
datadog-agent-aarch64-rpm 0.00MB 944.24MB 944.24MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 505.11MB 505.11MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.81MB 108.81MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.88MB 108.88MB 10.00MB

Decision

✅ Passed

tasks/libs/ciproviders/github_actions_tools.py Outdated Show resolved Hide resolved
tasks/github_tasks.py Outdated Show resolved Hide resolved
tasks/github_tasks.py Outdated Show resolved Hide resolved
tasks/github_tasks.py Outdated Show resolved Hide resolved
tasks/github_tasks.py Outdated Show resolved Hide resolved
tasks/libs/ciproviders/github_actions_tools.py Outdated Show resolved Hide resolved
.gitlab/trigger_release/trigger_release.yml Outdated Show resolved Hide resolved
.gitlab/trigger_release/trigger_release.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Dec 24, 2024
tasks/github_tasks.py Outdated Show resolved Hide resolved
tasks/github_tasks.py Show resolved Hide resolved
@Pythyu Pythyu requested a review from alopezz December 24, 2024 15:02
@Pythyu
Copy link
Contributor Author

Pythyu commented Dec 24, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 24, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-24 16:38:05 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.


2024-12-24 17:11:18 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3f413d8 into main Dec 24, 2024
230 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pythyu/windows_gitlab_runner_bump branch December 24, 2024 17:11
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants