replace bunch of get(x).is_some() by contains(x) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
=======================================
Coverage 85.60% 85.60%
=======================================
Files 27 27
Lines 10193 10193
=======================================
Hits 8726 8726
Misses 1467 1467 ☔ View full report in Codecov by Sentry. |
DanielT
reviewed
Nov 15, 2023
| @@ -70,7 +70,7 @@ fn generate_block_writer_generic(typename: &str, structitems: &[DataItem]) -> To | |||
|
|
|||
| quote! { | |||
| impl #typeident { | |||
| pub(crate) fn stringify(&self, indent: usize) -> String { | |||
| pub fn stringify(&self, indent: usize) -> String { | |||
There was a problem hiding this comment.
If the stringify function is useful to you, then it could definitely be made public.
That should be a separate commit though, not part of the cleanup.
There was a problem hiding this comment.
oups! this is some debug leftovers. sorry!
|
Aside fom the stringify change this is a nice cleanup. If you push an update, I will merge the change. |
Signed-off-by: Pierre Tardy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
was doing some cleanup algorithms on my a2l files, and found out that there is more or less same algorithm already in the public a2lfile api, but implemented with get(x).is_some()
It is actually implemented the same at low level, but this is a arguably more idiomatic