use error type for A2lFile.write() as well #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with 1.4.0 the parse api is now returning error. Fix the api to have this for write as well. this allows the client to just call write(..)? in a main function Signed-off-by: Pierre Tardy <[email protected]>
in order to be more consistent, I simplified the code to use map_err everywhere map_err beeing the rust idiomatic way to convert errors, compared to pattern matching Signed-off-by: Pierre Tardy <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 85.63% 85.60% -0.03%
==========================================
Files 27 27
Lines 10199 10193 -6
==========================================
- Hits 8734 8726 -8
- Misses 1465 1467 +2 ☔ View full report in Codecov by Sentry. |
|
I like it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following up the change in 1.4.0, this is a conversion to thiserror for write() api.
This is a breaking change.
I also changed a bit the other part of the error handling to be consistent in the use of map_err