Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mc_truth/interaction + true_pos in prompt_hit + backtrack #128

Merged
merged 25 commits into from
Jun 7, 2024

Conversation

YifanC
Copy link
Collaborator

@YifanC YifanC commented Jun 4, 2024

  • Fill mc_truth/interactions with vertices when there is no mc_hdr available. (closed PR mc_truth/interactions #126 )
  • Added true drift position and true energy reconstructed hits. (closed PR add true position and E to hits dataset #127 )
  • Adapted to use configuration instead hardcoded numbers for hit reconstruction (closed PR add true position and E to hits dataset #127 )
  • Copy the mc_packets_assn from larndsim output to mc_truth/packet_fraction and propagate it to mc_truth/calib_prompt_hit_backtrack
  • Adapted calib_hit_merger.py to consume the updated mc_truth/calib_prompt_hit_backtrack instead.
  • Use index for referencing between the packet and segment instead of taking segment_id as indices for references. Together with this PR for larndsim, we can get rid of the hotfix for segment updates.

Note:

  • event_ids are now available in mc_truth/packet_fraction and mc_truth/calib_prompt_hit_backtrack. event_id is not yet available in mc_truth/calib_final_hit_backtrack (to be added). mc_truth/calib_final_hit_backtrack data type is still defined manually, which can be updated too.
  • In the backtracking datasets, segment_ids is used instead segment_id given this is what's been called in larnd-sim. We can change the name in larndsim if it's preferred. In truth dataset, we use segment_id.
  • The data and ref all look reasonable to me. From validating the output ofmc_truth/calib_final_hit_backtrack, I noticed some differences using this feature branch vs. using develop (commit f58217e). The differences are inherited from mc_truth/calib_prompt_hit_backtrack. Given in this feature branch it's a direct copy from the larndsim ouput and the develop version reshape and remask a few times, I am convinced the problem is in the develop branch, but I cannot explain what was wrong.

@YifanC YifanC requested review from krwood, diaza, mjkramer and cuddandr June 4, 2024 09:06
@YifanC
Copy link
Collaborator Author

YifanC commented Jun 4, 2024

Minor comments in Git Issue #129

@YifanC
Copy link
Collaborator Author

YifanC commented Jun 4, 2024

Copy link
Member

@mjkramer mjkramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation plots look identical to MR5-beta1

@YifanC
Copy link
Collaborator Author

YifanC commented Jun 5, 2024

Validation plots look identical to MR5-beta1

Cool! @mjkramer Thanks for checking! I think we should add some backtracking part in the sim flow validation plots. (The backtracking info are different in beta1 and this version. The beta1 or current develop version doesn't seem to be correct.)

@diaza
Copy link
Member

diaza commented Jun 5, 2024

Could I ask what "true energy reconstructed hits" means? Is it the true charge deposited on the pixels, or the true dE deposited in the argon?

@YifanC
Copy link
Collaborator Author

YifanC commented Jun 5, 2024

@diaza E_true_recomb_elife means using true drift time and true dEdx for recombination to correct the energy of the hits. Note that I manually put the true lifetime in the config.

@YifanC YifanC merged commit 4f4f7f0 into develop Jun 7, 2024
2 checks passed
@mjkramer mjkramer deleted the feature_backtrack branch July 25, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants