-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mc_truth/interaction + true_pos in prompt_hit + backtrack #128
Conversation
use warning instead of a mix of warning and print
… feature_interaction
Minor comments in Git Issue #129 |
Some screenshots of some output: https://indico.fnal.gov/event/64988/contributions/293232/attachments/178588/243452/2024_06_04_ndlar_flow_readiness.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation plots look identical to MR5-beta1
Cool! @mjkramer Thanks for checking! I think we should add some backtracking part in the sim flow validation plots. (The backtracking info are different in beta1 and this version. The beta1 or current develop version doesn't seem to be correct.) |
Could I ask what "true energy reconstructed hits" means? Is it the true charge deposited on the pixels, or the true dE deposited in the argon? |
@diaza |
mc_packets_assn
from larndsim output tomc_truth/packet_fraction
and propagate it tomc_truth/calib_prompt_hit_backtrack
mc_truth/calib_prompt_hit_backtrack
instead.segment_id
as indices for references. Together with this PR for larndsim, we can get rid of the hotfix for segment updates.Note:
event_ids
are now available inmc_truth/packet_fraction
andmc_truth/calib_prompt_hit_backtrack
.event_id
is not yet available inmc_truth/calib_final_hit_backtrack
(to be added).mc_truth/calib_final_hit_backtrack
data type is still defined manually, which can be updated too.segment_ids
is used insteadsegment_id
given this is what's been called in larnd-sim. We can change the name in larndsim if it's preferred. In truth dataset, we usesegment_id
.mc_truth/calib_final_hit_backtrack
, I noticed some differences using this feature branch vs. using develop (commit f58217e). The differences are inherited frommc_truth/calib_prompt_hit_backtrack
. Given in this feature branch it's a direct copy from the larndsim ouput and the develop version reshape and remask a few times, I am convinced the problem is in the develop branch, but I cannot explain what was wrong.