-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDLAr
flow workflow
#107
NDLAr
flow workflow
#107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There are a couple of empty.yaml files that may not need to be committed
Thanks Kevin! Regarding the empty yamls I was taking the lead from here - I thought maybe important for the build or running h5flow. |
This PR brings the "first" version of an
ndlar_flow
workflow for a full NDLAr geometry intodevelop
. An important thing to note for this PR is that nothing here will have any impact on the 2x2 workflow unless a user wants it to.Things are set up such that, with the exception of the geometry resource, all resources that are used are the
protons_nd_flow
ones (the ones used by 2x2) with NDLAr specific configurations where necessary. For example:points back to
which in turn points back to
The module pointed back to in this
yaml
fromproto_nd_flow
but one of the parameter is changed to be NDLAr appropriate
As originally suggested by @krwood, the geometry service can (and should in the future) be used as a common, detector agnostic version of the 2x2 hardcoded
proto_nd_flow/resources/geometry.py
. For now it is only tested with full NDLAr.I gave a talk at the May collaboration meeting discussing these changes in detail (with a full suite of validation plots).
Work since then has been tweaks - bringing the branch up to date with
develop
and testing with updated inputs. A latest set of validation plots can be found at docdb-31528 in thepdf
MicroProd*flow*
(minus any plots usingcalib_final_hits
since, like 2x2, the 5th charge workflow is not being run).