Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDLAr flow workflow #107

Merged
merged 23 commits into from
Aug 7, 2024
Merged

NDLAr flow workflow #107

merged 23 commits into from
Aug 7, 2024

Conversation

alexbooth92
Copy link
Member

@alexbooth92 alexbooth92 commented Feb 20, 2024

This PR brings the "first" version of an ndlar_flow workflow for a full NDLAr geometry into develop. An important thing to note for this PR is that nothing here will have any impact on the 2x2 workflow unless a user wants it to.

Things are set up such that, with the exception of the geometry resource, all resources that are used are the protons_nd_flow ones (the ones used by 2x2) with NDLAr specific configurations where necessary. For example:

yamls/ndlar_flow/workflows/charge/charge_event_building.yaml

points back to

raw_event_generator: # groups time-sorted data packets from larpix datalog files
  !include yamls/ndlar_flow/reco/charge/RawEventGenerator.yaml

which in turn points back to

yamls/ndlar_flow/reco/charge/RawEventGenerator.yaml.

The module pointed back to in this yaml from proto_nd_flow

path: proto_nd_flow.reco.charge.raw_event_generator

but one of the parameter is changed to be NDLAr appropriate

  event_builder_config:
    window: 3000 # ExtTrigRawEventBuilder

As originally suggested by @krwood, the geometry service can (and should in the future) be used as a common, detector agnostic version of the 2x2 hardcoded proto_nd_flow/resources/geometry.py. For now it is only tested with full NDLAr.

I gave a talk at the May collaboration meeting discussing these changes in detail (with a full suite of validation plots).

Work since then has been tweaks - bringing the branch up to date with develop and testing with updated inputs. A latest set of validation plots can be found at docdb-31528 in the pdf MicroProd*flow* (minus any plots using calib_final_hits since, like 2x2, the 5th charge workflow is not being run).

Alexander Booth and others added 23 commits February 20, 2024 00:21
…rc/resources/geometry.py. Only changes from two commits that needed to be done: 757f337 and ad12385.
…uently use them) if we are doing charge only.
This reverts commit c1423ab.
Copy link
Member

@krwood krwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There are a couple of empty.yaml files that may not need to be committed

@alexbooth92
Copy link
Member Author

Looks good to me. There are a couple of empty.yaml files that may not need to be committed

Thanks Kevin! Regarding the empty yamls I was taking the lead from here - I thought maybe important for the build or running h5flow.

@YifanC YifanC merged commit 2568067 into develop Aug 7, 2024
2 checks passed
@alexbooth92 alexbooth92 deleted the production-MiniProdN2p1 branch August 7, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants