Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hit merging #129

Open
YifanC opened this issue Jun 4, 2024 · 0 comments
Open

Hit merging #129

YifanC opened this issue Jun 4, 2024 · 0 comments

Comments

@YifanC
Copy link
Collaborator

YifanC commented Jun 4, 2024

One parameter we can potentially tune is the event chunk size here:


Because the hits are padded to the maximum number of the prompt hits of any event in this chunk. I think it would be helpful to have smaller chunk size.
My naive understanding is that these three parameters here are not independent.
I think the minimum time time between hits are ~15ticks (please correct me), so it won't merge more than 5 merge steps, and max_contrib_segments can be 5 x 10 (where 5 is the merge steps and 10 is placeholder for the number of stored segments per prompt hit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant