Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upstream] Limit task creation by access controll #72

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Upstream] Limit task creation by access controll #72

wants to merge 1 commit into from

Conversation

JM-Lemmi
Copy link
Member

Now we first evaluate ctfnote_private.can_play_ctf before adding a task.
If it is not true (value can also be null), then we do not create
and add the pad.
This prevents guests from adding tasks to CTFs they
are not allowed to participate in.

@JJ-8 @JM-Lemmi
Limit task creation by access controll
8ca925e 
Now we first evaluate `ctfnote_private.can_play_ctf` before adding a task.
If it is not true (value can also be `null`), then we do not create
and add the pad.
This prevents guests from adding tasks to CTFs they
are not allowed to participate in.
@JM-Lemmi JM-Lemmi changed the base branch from main to develop April 24, 2022 13:32
@JM-Lemmi JM-Lemmi added the enhancement New feature or request label Apr 24, 2022
ElevenSpins
ElevenSpins approved these changes Apr 26, 2022
View reviewed changes
Copy link

@ElevenSpins ElevenSpins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vernünftig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElevenSpins ElevenSpins ElevenSpins approved these changes

@xTomsko xTomsko Awaiting requested review from xTomsko

@frereit frereit Awaiting requested review from frereit

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JM-Lemmi @ElevenSpins @JJ-8