Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for AA script duplication #739

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Tests for AA script duplication #739

merged 2 commits into from
Oct 18, 2024

Conversation

Charles-Pham
Copy link
Contributor

ADO-280112

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary

Description of proposed changes:

Add test that the AA scripts load only once. Couldn't find a way to test the race condition, so added a comment for why AA script needs to be loaded beforeInteractive.

What to test for/How to test

Tests should pass.

Additional Notes

@Charles-Pham Charles-Pham requested a review from a team as a code owner October 18, 2024 18:33
Copy link

Copy link
Contributor

@jhslater jhslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Charles-Pham Charles-Pham merged commit 8262fa5 into dev Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants