Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact us page to display SIN link #706

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

krischarbonneau
Copy link
Contributor

@krischarbonneau krischarbonneau commented Jul 16, 2024

ADO-249297

Fixed AB#249297

Changelog

feat:Updated contact us mapper and contact us page to display SIN

Description of proposed changes:

This PR updates our contact-us mapper with the SIN links and the contact-us index page to accommodate external links.

What to test for/How to test

  1. Pull in branch
  2. Type npm run dev
  3. Navigate to the contact us page and ensure that the SIN link is there and clicking it opens the canada.ca link in a new tab

Additional Notes

I feel like the contact-us mapper could potentially be made dynamic so we don't have to manually make these changes in the future. So something to look into.

@krischarbonneau krischarbonneau requested a review from a team as a code owner July 16, 2024 15:11
Copy link

azure-boards bot commented Jul 16, 2024

✅ Successfully linked to Azure Boards work item(s):

Copy link

Copy link
Collaborator

@shewood shewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krischarbonneau krischarbonneau merged commit cb302dd into dev Jul 16, 2024
8 checks passed
@krischarbonneau krischarbonneau deleted the contact-us-sin branch July 16, 2024 15:40
krischarbonneau added a commit that referenced this pull request Jul 29, 2024
* Update footer ternary to use publicRuntimeConfig value (#705)

* Update contact us page to display SIN link (#706)

* Add Root Cert Structure to Dockerfile (#707)

* Pin base image version in Dockerfile (#709)

---------

Co-authored-by: lhr-git <[email protected]>
lhr-git added a commit that referenced this pull request Aug 21, 2024
* Update footer ternary to use publicRuntimeConfig value (#705)

* Update contact us page to display SIN link (#706)

* Add Root Cert Structure to Dockerfile (#707)

* Pin base image version in Dockerfile (#709)

* Update next-auth config to validate  SIN and UID (#710)

* Swapping from null to a catchall for falsy values (#711)

* Swapping from null to a catchall for falsy values (#711) (#712)

* Snyk updates bundled together (#714)

* Merging dev into staging August 19, 2024 (#715)

* Swapping from null to a catchall for falsy values (#711)

* Snyk updates bundled together (#714)

---------

Co-authored-by: Kris Charbonneau <[email protected]>
Co-authored-by: Kris Charbonneau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants