Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sch 211658 tandc #675

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Sch 211658 tandc #675

merged 7 commits into from
Jun 27, 2024

Conversation

shewood
Copy link
Collaborator

@shewood shewood commented Jun 4, 2024

ADO-211658

AB#211658

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary

feat: use ecas links for t&c

Description of proposed changes:

use ecas links for t and c and privacy in the footer.
removed references to the page.

What to test for/How to test

test footer links to make sure they work (need auth for it)

Additional Notes

@shewood shewood requested a review from a team as a code owner June 4, 2024 20:31
Copy link

github-actions bot commented Jun 4, 2024

@shewood shewood marked this pull request as draft June 4, 2024 20:31
@shewood shewood marked this pull request as ready for review June 26, 2024 20:00
locales/fr.js Outdated Show resolved Hide resolved
Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for the most part, just a comment on the naming sense for the dev URLS

@shewood shewood requested a review from krischarbonneau June 27, 2024 14:22
Copy link
Contributor

@krischarbonneau krischarbonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shewood shewood merged commit 788f3d0 into dev Jun 27, 2024
8 checks passed
@krischarbonneau krischarbonneau deleted the sch-211658-tandc branch July 5, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants