Merge pull request #750 from DTS-STN/default-param

Fix alerts not appearing
DTS-STN · Nov 8, 2024 · f11d0cc · f11d0cc
2 parents 3f33b91 + 6bd269b
commit f11d0cc
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 22 deletions.
diff --git a/__tests__/components/Card.test.js b/__tests__/components/Card.test.js
@@ -33,4 +33,6 @@ describe('Card', () => {
     const results = await axe(container)
     expect(results).toHaveNoViolations()
   })
+
+  // TODO: Add a test that if an alert is added it actually appears
 })
diff --git a/components/Card.tsx b/components/Card.tsx
@@ -35,7 +35,6 @@ const Card = ({
       alert_icon_id: '',
     },
   ],
-  hasAlert,
   locale,
   cardTitle,
   viewMoreLessCaption,
@@ -111,27 +110,23 @@ const Card = ({
       />
       {!isOpen ? null : (
         <div>
-          {hasAlert &&
-            cardAlert.map((alert, index) => {
-              const alertType = alert.type[0].split('/').pop()
-              return (
-                <ul
-                  className="w-full pb-3 sm:px-8 sm:pb-6 md:px-15"
-                  key={index}
-                >
-                  <ContextualAlert
-                    id={alert.id}
-                    type={alertType}
-                    alertHeading={alert.alertHeading}
-                    alertBody={alert.alertBody}
-                    alert_icon_alt_text={`${alertType} ${
-                      locale === 'fr' ? 'Icônes' : 'icon'
-                    }`}
-                    alert_icon_id={` alert-icon ${alert.id}`}
-                  />
-                </ul>
-              )
-            })}
+          {cardAlert.map((alert, index) => {
+            const alertType = alert.type[0].split('/').pop()
+            return (
+              <ul className="w-full pb-3 sm:px-8 sm:pb-6 md:px-15" key={index}>
+                <ContextualAlert
+                  id={alert.id}
+                  type={alertType}
+                  alertHeading={alert.alertHeading}
+                  alertBody={alert.alertBody}
+                  alert_icon_alt_text={`${alertType} ${
+                    locale === 'fr' ? 'Icônes' : 'icon'
+                  }`}
+                  alert_icon_id={` alert-icon ${alert.id}`}
+                />
+              </ul>
+            )
+          })}
           <div className="pb-6" data-cy="sectionList">
             {children}
           </div>