142179 - Refactor Alert and Heading #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dynamic branch URL: https://ep-be-dyna-alert.bdm-dev-rhp.dts-stn.com |
shawn320
requested review from
alex-solo,
MarcoGoC,
numbap,
wassila-aouchiche and
Maxim-Lam
|
Dynamic branch URL: https://ep-be-dyna-alert.bdm-dev-rhp.dts-stn.com |
MarcoGoC
reviewed
Oct 5, 2023
|
Dynamic branch URL: https://ep-be-dyna-alert.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-alert.bdm-dev-rhp.dts-stn.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove DS from the project (142179)
Description
What to test for/How to test
The ContextualAlert is imported on index.tsx as Message. Try to change
typeprop to check different type of alert. There are 4 types: info, success, warning, danger. Different type should show different icon and color.EE was using an outdated version of the DS Alert, to checkout latest design, visit Figma
Additional Notes