142112 - Replace DS Header #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dynamic branch URL: https://ep-be-dyna-update-header.bdm-dev-rhp.dts-stn.com |
|
Dynamic branch URL: https://ep-be-dyna-update-header.bdm-dev-rhp.dts-stn.com |
shawn320
requested review from
Maxim-Lam,
numbap,
alex-solo,
MarcoGoC and
wassila-aouchiche
|
Dynamic branch URL: https://ep-be-dyna-update-header.bdm-dev-rhp.dts-stn.com |
wassila-aouchiche
previously approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Could you please change the line to 1px like the other gc websites (based on @MarcoGoC comment).
Thanks!
|
Dynamic branch URL: https://ep-be-dyna-update-header.bdm-dev-rhp.dts-stn.com |
Updated! |
wassila-aouchiche
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 142112: Breadcrumb/ Header fix
Description
The purpose of this pr is to remove the DS Header and build our own Header.
The Header should include:
Menu and Searchbar will be added in the future
List of proposed changes:
What to test for/How to test
Additional Notes
AB#142112