Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

137225-duplicate-results #878

Closed
wants to merge 4 commits into from
Closed

Conversation

Maxim-Lam
Copy link
Contributor

@Maxim-Lam Maxim-Lam commented Aug 31, 2023

137225 (Duplicate result in different section)

Description

  • fixed duplicate results still showing up

List of proposed changes:

  • moved the code to remove duplicates to the utils
  • remove duplicates happens before the array is passed to WillBeElligible component

What to test for/How to test

Additional Notes

AB#137225

@github-actions
Copy link

@github-actions
Copy link

@Maxim-Lam Maxim-Lam marked this pull request as ready for review September 21, 2023 13:37
@Maxim-Lam Maxim-Lam changed the title Hotfix-duplicate-results 137225-duplicate-results Sep 21, 2023
@github-actions
Copy link

Copy link
Contributor

@wassila-aouchiche wassila-aouchiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maxim-Lam could you please close this PR? Thank you :)

@wassila-aouchiche wassila-aouchiche self-requested a review October 12, 2023 12:33
@wassila-aouchiche wassila-aouchiche deleted the hotfix-duplicate-results branch October 12, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants