Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix results page on language toggle #1124

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

alex-solo
Copy link
Collaborator

AB#NNN - Description here

Description

  • Because some of the text and card details is stored in the calculated results object, we have to run the calc again when the language is being toggled to "refresh" it to the correct language

Copy link

@MarcoGoC MarcoGoC self-requested a review December 2, 2024 16:38
Copy link
Contributor

@MarcoGoC MarcoGoC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, thanks

@alex-solo alex-solo merged commit d3fe1a6 into develop Dec 2, 2024
5 checks passed
@alex-solo alex-solo deleted the language-toggle-results branch December 2, 2024 16:51
alex-solo added a commit that referenced this pull request Dec 17, 2024
* Fix results page on language toggle (#1124)

fix results page on language toggle

* removing months from the age

---------

Co-authored-by: Alex Soloviev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants