Sync develop with Main for release candidate v1.5.0 #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial commit * new files * dont pass children as props * display inputs for different steps * form updates * apos symbol * create component factory * refresh components on language change * duration and ageDate added * removing design system css * port over css styles for tooltip and adjust radio options * fixed tooltip css * style of stepper title * styled buttons * include dynamic metadata for income question currency component * switch between lanbguages * minor * changed to correct language on few components * make sure language of the income label and hints changes with global language change * add your and partner information text * added french text * removed help from one of the questions * new requirement for partner benefit status question * scroll up every time a step is changed * fix regex so french currency works and moved the dollar sign outside of the input * keep the active page state in session so we stay on the right page during refresh * make sure the partner age is valid before showing the benefit status question * fix error when ageDate did not update * update the intro page * fix sanitization to only affect currency * start of adding error messages * keep track of visible errors in session for each step * fixed error on itital renderng of oasDeferDuration question * fixed error related to Duration component when changing active step * basic error handling * error summary stylings * add button attributes to next button so it works with adobe analytics * ability to go back to edit questions * code cleanup, delete questions page replace with stepper * comments * delete old accordion form page * change benefits.test.ts to reflect lack of legal status question * fix tests * fix tests * fix tests * fix tests * fix tests * fix tests * temporary comment out some tests * empty commit to push * change schema to set partnerBenefitStatus to none when residency req is not met * added new field for partner residence since OAS in the case they already receive OAS * validation and error messages on partner residency if they lived in canada or outside * saving progress - accommodate the new field for partner residency * delete notion of partner years since oas. Only care about years since 18 * save progress * trying to make tests pass * all tests pass * all tests pass * updated with latest rates to deal with merge conflict * change order of questions in what you told us section * fix bug related to income field showing zero value * change order in some of the failing tests * fixed wrong error message for partner * empty commit to push * addressed some comments relating to fonts and headers * fixed button focus on step change * fixed font sizes in hint expander as well as added vertical line * added french help text to partner residence question * fixed spelling * additional help text when client has partner * added aria label to select * made changes based on ITAO audit * added contact us to the link label for a11y reader * fixed html semantics, got rid of nested h1 * changed html structure of questions. Got rid of fieldset and legend and use labels for inputs instead * make the page title dynamic so it reflects the current step * keep the colour the same on the topnav links even when visited * changed out warning alert and changed the messaging * select and focus the target * added ids as constants to pass as props * changed id to not overlap * empty commit to push * fixed the first page to match the new design system * remove the WIP alert from stepper pages and fix spacing * fixed spelling * save progress * the options now update correctly when age date changes * fixed the issue of having different button heights * fixed colour of tooltip and spacing * scroll to the first error on the page * SSA question should not appear if client is already receiving OAS * fixed hr adding a default 1px to its border * added new input to schema and changed the verification logic * fix logic to accomodate new field * set step to 1 in session storage when clicking on the start link * add spacing for partner income help * added missing word in french * prevent button text wrap * fixed the border issue on the eligibility tag component * changed the border width to match the design * make tests pass * bring back the consoleDev * fixed button behaviour * button fits the narrow width screen * maintain question order on results page when mobile
Fixed previous deployment error
Revert the back button behaviour and fixed a couple bugs
* use query strings to help navigate through stepper * save results for the results page to display * changed the any type to be more specific to response and inputs * add a navigation warning
dangerously set HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
List of proposed changes:
Additional Notes