Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

219714 - Updated css for visited links #1085

Merged
merged 2 commits into from
Jun 18, 2024
Merged

219714 - Updated css for visited links #1085

merged 2 commits into from
Jun 18, 2024

Conversation

MarcoGoC
Copy link
Contributor

@MarcoGoC MarcoGoC commented Jun 18, 2024 •
edited by azure-boards bot
Loading

AB#219714 - Visited links

Description

  • The main purpose was visited links, however as part of those changes many, options had to be modified
  • All links have a class that adds the svg for OpenNewTab
  • adding missing aria-label for 'open an new tab'

List of proposed changes:

  • as described above

What to test for/How to test

  • dl and run

Additional Notes

@MarcoGoC MarcoGoC requested review from alex-solo and Maxim-Lam June 18, 2024 17:58
@github-actions GitHub Actions
Copy link

Dynamic branch URL: https://app-eligibilityestimator-dev-pr-preview-1.azurewebsites.net

alex-solo
alex-solo approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@alex-solo alex-solo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of cascading changes, let's test once merged.

@MarcoGoC MarcoGoC merged commit f0d96ea into develop Jun 18, 2024
5 checks passed
@MarcoGoC MarcoGoC deleted the 219714-visited branch June 18, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-solo alex-solo alex-solo approved these changes

@Maxim-Lam Maxim-Lam Awaiting requested review from Maxim-Lam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoGoC @alex-solo