Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dont round the future age to get accurate age at first eligibility #1067

Merged
merged 1 commit into from
Jun 6, 2024
Merged

dont round the future age to get accurate age at first eligibility #1067

merged 1 commit into from
Jun 6, 2024

Conversation

alex-solo
Copy link
Collaborator

AB#NNN - Description here

Description

  • This ADO task was already completed under a different name ("residency under 10 years") but this PR is simply a bug fix that leaves the ages not floored so we can know precisely the age when someone becomes eligible with years and months.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Dynamic branch URL: https://app-eligibilityestimator-dev-pr-preview-3.azurewebsites.net

MarcoGoC
MarcoGoC approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@MarcoGoC MarcoGoC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not exactly sure what is this lol

@alex-solo alex-solo merged commit a0c663e into develop Jun 6, 2024
4 checks passed
@alex-solo alex-solo deleted the ado-133070 branch June 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGoC MarcoGoC MarcoGoC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-solo @MarcoGoC