-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagination to submission lists #2882
base: main
Are you sure you want to change the base?
Add pagination to submission lists #2882
Conversation
Why can't we |
We can but that will reload the page every time, which looks very ugly and makes it that focus of the field is lost, so filtering on 2 teams is super annoying. What we could do is somehow do some AJAX submit and update in the background. However, I didn't want to go there since that makes it even more complex and I don't think hitting one button is that big of an issue. |
'results' => $results, | ||
'showExternalResult' => $this->dj->shadowMode(), | ||
'showTestcases' => count($submissions) <= $latestCount, | ||
'showTestcases' => true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used anywhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only show it on the general submission page and not others (like team page, judgehost page, etc.). So yes.
Co-authored-by: MCJ Vasseur <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing more to ask about it.
Fixes #2511
Some notes:
page
. We can't currently override this, see pageParameterName not supported KnpLabs/KnpPaginatorBundle#815.Screenshots: