Prevent import-examples to fail #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Dec 5, 2024
The mariadb images seems to now allow a smaller maximum packet by default. This resulted in problems for the boolfind problem which we didn't detect as all checks would still pass correctly. We now also capture the SQL logs to detect this easier and increase the maximum packetsize (1G).
|
The other errors will be fixed in #2876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mariadb images seems to now allow a smaller maximum packet by default. This resulted in problems for the boolfind problem which we didn't detect as all checks would still pass correctly.
We now also capture the SQL logs to detect this easier and increase the maximum packetsize (1G).
When this is accepted I'll move the installation of the
docker.ioto the runner image and remove that line for a small speedup.