Disable the judgehost when default system commands fail #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
disable_scripts_judgedaemon_fixme
branch
from
032e199 to
640ddd5
Compare
meisterT
approved these changes
Nov 22, 2024
All of those actions are default system command like creating or cleaning up needed files/directories. Those should never fail so if they do we can't really trust this judgehost anymore until we inspected the host. Leftover is the disabling of debug_scripts when we can't run those as we don't have a dependant entity like for languages/problems which we can disable in its place. The closest thing would be the `default_debug_script` key in the config which is a bit brittle. A suggestion is to either store this as a fact with the executable or put in the work to remove this as the default option in the config. Also swapped one function to the non-internal function which handles the disabling already.
vmcj
force-pushed
the
disable_scripts_judgedaemon_fixme
branch
from
640ddd5 to
cfc74dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of those actions are default system command like creating or cleaning up needed files/directories. Those should never fail so if they do we can't really trust this judgehost anymore until we inspected the host.
Leftover is the disabling of debug_scripts when we can't run those as we don't have a dependant entity like for languages/problems which we can disable in its place. The closest thing would be the
default_debug_scriptkey in the config which is a bit brittle. A suggestion is to either store this as a fact with the executable or put in the work to remove this as the default option in the config.Also swapped one function to the non-internal function which handles the disabling already.
This is part of #2745 but as that PR handles 3 semi-unrelated fixme's it's better to keep the discussion separate.