Add option to upload languages configuration via API. #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
reviewed
Sep 30, 2023
nickygerritsen
approved these changes
Sep 30, 2023
| continue; | ||
| } | ||
| $lang->setAllowSubmit(true); | ||
| if (isset($language['name'])) { |
There was a problem hiding this comment.
We could use a PropertyAccessor loop here to get rid of most duplication. See also the problem import somewhere (I believe)
There was a problem hiding this comment.
I tried this and it was not really less code / more understandable (probably also because of the nested compiler/runner fields). Feel free to submit to this branch.
vmcj
reviewed
Sep 30, 2023
| [$idField => $lang_id] | ||
| ); | ||
| if (!$lang) { | ||
| continue; |
There was a problem hiding this comment.
Should we not indicate this to the one uploading that the language is missing?
There was a problem hiding this comment.
Yes, and no:
- Logging is not really possible as we return the updated languages config, so that it can be compared in the script.
- We could error out, but that's quite brutal.
- We could try adding a new language, but of course stuff like executables are missing here.
What about this: I will add a TODO comment here for now; and when we decided on the best solution we can replace it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2142.