Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto calculate num actions for jury tables. #2161

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Auto calculate num actions for jury tables. #2161

merged 1 commit into from
Oct 4, 2023

Conversation

Suckzoo
Copy link
Contributor

@Suckzoo Suckzoo commented Sep 27, 2023

ContestController is broken in 8.2.1. (#2160)

This PR cherry-picks 1294b6e.

nickygerritsen
nickygerritsen requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to work as is, since the older PHP/Symfony we use doesn't understand the #[Route] etc. I will see if I can properly backport this.

@nickygerritsen
Auto calculate num actions for jury tables.
957f6e9 
(cherry picked from commit 1294b6e)

# Conflicts:
#	webapp/src/Controller/Jury/ExecutableController.php
#	webapp/src/Twig/TwigExtension.php
@nickygerritsen
Copy link
Member

Thanks for the initial change, I updated it.

@nickygerritsen nickygerritsen merged commit 8f523ae into DOMjudge:8.2 Oct 4, 2023
15 of 16 checks passed
@vmcj vmcj mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suckzoo @nickygerritsen