Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added problem badges #2151

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Added problem badges #2151

merged 1 commit into from
Oct 7, 2023

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Sep 21, 2023

image

@vmcj vmcj force-pushed the executables_problem_badges branch from cdfd20a to 296af44 Compare September 21, 2023 20:20
@vmcj vmcj requested a review from meisterT September 22, 2023 08:00
nickygerritsen
nickygerritsen approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code style warnings but besides that LGTM

@vmcj vmcj force-pushed the executables_problem_badges branch from 296af44 to 90ea66a Compare October 5, 2023 19:34
@vmcj
Copy link
Member Author

vmcj commented Oct 5, 2023 •
edited
Loading

image
D is double as it has both type of executables. I left the defaults out mostly as its very expensive and it would just cluther the interface IMO.

I tried to improve the speed of the queries when handling Tobi his remarks. @nickygerritsen this is non-trivial with Doctrine is there a better way?

@vmcj vmcj linked an issue Oct 5, 2023 that may be closed by this pull request
Possibility of removing/adding new file to executable #1526
Closed
nickygerritsen
nickygerritsen approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to improve the speed of the queries when handling Tobi his remarks. @nickygerritsen this is non-trivial with Doctrine is there a better way?

Besides doing direct queries or maybe a DQL, I don't think so

webapp/templates/jury/jury_macros.twig Outdated
@@ -141,6 +141,10 @@
{{- (item.value|default(item.default|default('')))|affiliationLogo(item.title) -}}
{% elseif key == "warning_content" %}
{{- item.value|printWarningContent -}}
{% elseif key == "badges" %}
{% for badge in item.value %}
{{- badge|problemBadge -}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want a space between the badges?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Fine by me.

@vmcj vmcj force-pushed the executables_problem_badges branch from 90ea66a to a5685de Compare October 6, 2023 18:34
@vmcj vmcj merged commit 82a1cd0 into DOMjudge:main Oct 7, 2023
18 checks passed
@vmcj vmcj deleted the executables_problem_badges branch October 7, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen approved these changes

@meisterT meisterT meisterT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility of removing/adding new file to executable
3 participants
@vmcj @meisterT @nickygerritsen