Make shadowing a bit more robust

All these were found while shadowing PC^2.
DOMjudge · Nov 12, 2024 · c03867c · c03867c
1 parent 40839ae
commit c03867c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 6 deletions.
diff --git a/webapp/src/Command/ImportEventFeedCommand.php b/webapp/src/Command/ImportEventFeedCommand.php
@@ -223,10 +223,12 @@ protected function compareContestId(): bool
         $ourId   = $contest->getExternalid();
         $theirId = $this->sourceService->getContestId();
         if ($ourId !== $theirId) {
-            $this->style->error(
+            $this->style->warning(
                 "Contest ID in external system $theirId does not match external ID in DOMjudge ($ourId)."
             );
-            return false;
+            if (!$this->style->confirm('Do you want to continue anyway?', default: false)) {
+                return false;
+            }
         }
 
         return true;

diff --git a/webapp/src/DataTransferObject/ApiInfo.php b/webapp/src/DataTransferObject/ApiInfo.php
@@ -7,8 +7,8 @@
 class ApiInfo
 {
     public function __construct(
-        public readonly string $version,
-        public readonly string $versionUrl,
+        public readonly ?string $version,
+        public readonly ?string $versionUrl,
         public readonly string $name,
         public readonly ?ApiInfoProvider $provider,
         #[Serializer\Exclude(if: '!object.domjudge')]

diff --git a/webapp/src/DataTransferObject/Shadowing/ProblemEvent.php b/webapp/src/DataTransferObject/Shadowing/ProblemEvent.php
@@ -7,7 +7,7 @@ class ProblemEvent implements EventData
     public function __construct(
         public readonly string $id,
         public readonly string $name,
-        public readonly float $timeLimit,
+        public readonly ?float $timeLimit,
         public readonly ?string $label,
         public readonly ?string $rgb,
     ) {}

diff --git a/webapp/src/Service/ExternalContestSourceService.php b/webapp/src/Service/ExternalContestSourceService.php
@@ -1027,9 +1027,12 @@ protected function validateAndUpdateProblem(Event $event, EventData $data): void
 
         $toCheckProblem = [
             'name'      => $data->name,
-            'timelimit' => $data->timeLimit,
         ];
 
+        if ($data->timeLimit) {
+            $toCheckProblem['timelimit'] = $data->timeLimit;
+        }
+
         if ($contestProblem->getShortname() !== $data->label) {
             $this->logger->warning(
                 'Contest problem short name does not match between feed (%s) and local (%s), updating',
@@ -1097,7 +1100,10 @@ protected function validateAndUpdateTeam(Event $event, EventData $data): void
         if (!empty($data->organizationId)) {
             $affiliation = $this->em->getRepository(TeamAffiliation::class)->findOneBy(['externalid' => $data->organizationId]);
             if (!$affiliation) {
+                // Affiliation does not exist. Create one with a dummy name so we can continue.
                 $affiliation = new TeamAffiliation();
+                $affiliation->setName($data->organizationId);
+                $affiliation->setShortname($data->organizationId);
                 $this->em->persist($affiliation);
             }
             $team->setAffiliation($affiliation);
@@ -1106,7 +1112,9 @@ protected function validateAndUpdateTeam(Event $event, EventData $data): void
         if (!empty($data->groupIds[0])) {
             $category = $this->em->getRepository(TeamCategory::class)->findOneBy(['externalid' => $data->groupIds[0]]);
             if (!$category) {
+                // Category does not exist. Create one with a dummy name so we can continue.
                 $category = new TeamCategory();
+                $category->setName($data->groupIds[0]);
                 $this->em->persist($category);
             }
             $team->setCategory($category);