Skip to content

Commit

Permalink
Fix compiler error reporting for empty source file sets.
Browse files Browse the repository at this point in the history
Empty source file sets can happen with filtered file extensions, when
you accept a submission and later trim down the list of filtered file
extensions to a smaller set.

We also saw this during shadowing, but probably want to classify that as
an import error.
  • Loading branch information
meisterT committed Nov 14, 2024
1 parent 635d497 commit a806495
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion webapp/src/Controller/API/JudgehostController.php
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,12 @@ public function updateJudgingAction(
if ($judging->getOutputCompile() === null) {
$judging
->setOutputCompile($output_compile)
->setCompileMetadata(base64_decode($compileMetadata))
->setResult(Judging::RESULT_COMPILER_ERROR)
->setEndtime(Utils::now());

if ($compileMetadata !== null) {
$judging->setCompileMetadata(base64_decode($compileMetadata));
}
$this->em->flush();

if ($judging->getValid()) {
Expand Down

0 comments on commit a806495

Please sign in to comment.