Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic pressure fixes #147

Merged
merged 6 commits into from
Sep 13, 2023
Merged

Dynamic pressure fixes #147

merged 6 commits into from
Sep 13, 2023

Conversation

nieweber
Copy link
Contributor

Update documentation of all components taking dynamic pressure into account. This PR addresses #42 and adds an explanation of the sign convention for the velocity. An internal review on changing the sign convention of the velocity is still pending.

@nieweber nieweber requested a review from tobolar September 13, 2023 11:33
@nieweber nieweber self-assigned this Sep 13, 2023
@github-actions github-actions bot added p::Processes Concerns package Processes and Undirected.Processes p::Boundaries Concerns package Boundaries and Undirected.Boundaries labels Sep 13, 2023
Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me.

@nieweber nieweber merged commit fde5d85 into DLR-SR:main Sep 13, 2023
@nieweber nieweber deleted the dynamicPressureFixes branch September 13, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p::Boundaries Concerns package Boundaries and Undirected.Boundaries p::Processes Concerns package Processes and Undirected.Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants