Makefile improvements #594
Conversation
albfan
force-pushed
the
makefile-improvements
branch
from
a23fff8 to
36714b9
Compare
| enable_debug: | ||
| ./digimend-debug 1 | ||
|
|
||
| dkms_reinstall: dkms_uninstall dkms_install enable_debug |
There was a problem hiding this comment.
Hmm, I assume this would be useful for a development loop, to quickly test your changes. However, enabling debug shouldn't be a part of a general-purpose target. After removing it, its use for debugging becomes superficial, and you can just instead have a compound command in your history to do the same:
make dkms_uninstall dkms_install && digimend-debug 1
All-in-all, I think it's more trouble than it's worth, so could you please drop this patch?
| @@ -108,7 +108,7 @@ dkms_modules_uninstall: dkms_check | |||
| dkms status $(DKMS_MODULES_NAME) | \ | |||
| while IFS=':' read -r modules status; do \ | |||
| echo "$$modules" | { \ | |||
| IFS=', ' read -r modules_name modules_version \ | |||
There was a problem hiding this comment.
Thanks! I'm curious, though, where does that change come from? Has dkms status output format changed?
| @@ -102,6 +102,7 @@ dkms_modules_install: dkms_check | |||
| dkms add . | |||
| dkms build $(DKMS_MODULES) | |||
| dkms install $(DKMS_MODULES) | |||
| @! rmmod hid_uclogic | |||
There was a problem hiding this comment.
I'm hesitant about loading or unloading modules as part of (un)installation, since we don't really know which version of the module is loaded at that moment. At the very least this should be a part of an uninstall target, but I'd prefer, if you dropped this patch.
|
I will rebase on top of #629 and address your suggestions. Thanks for taking a look |
This is a series of fixes and improvements for makefile:
Let me know if any of this makes sense to cherry-pick or create new isolate PR